Sets Up Autotesting on SNL Machines #426
Conversation
mjschmidt271
requested review from
jaelynlitz,
jeff-cohere,
mam4xxSNL,
odiazib,
overfelt and
singhbalwinder
|
@jaelynlitz - It probably makes sense to also remove the PNNL workflow with this PR, so let me know if that works for you |
| @@ -0,0 +1,36 @@ | |||
| name: SNL-AT2 | |||
There was a problem hiding this comment.
I wonder if we should name this 'AT' only?
There was a problem hiding this comment.
The name of the software product that facilitates this is "AT2 (Autotester2)"--however, what we call it on our side doesn't make a bit of difference to me
|
Is this test failure an issue for this PR, or is it a known and unrelated thing? |
.github/workflows/at2_gcc-cuda.yml
Outdated
| uses: actions/checkout@v4 | ||
| with: | ||
| persist-credentials: false | ||
| show-progress: false | ||
| submodules: recursive | ||
| - name: Cloning Haero | ||
| uses: actions/checkout@v3 |
There was a problem hiding this comment.
Can we use the same version of checkout across the actions? 😄
.github/workflows/at2_gcc-cuda.yml
Outdated
| @@ -0,0 +1,104 @@ | |||
| name: gcc-cuda | |||
There was a problem hiding this comment.
What versions of gcc and cuda are we using?
.github/workflows/at2_gcc-cuda.yml
Outdated
| -DNUM_VERTICAL_LEVELS=72 \ | ||
| -DENABLE_COVERAGE=OFF \ | ||
| -DENABLE_SKYWALKER=ON \ | ||
| -DCMAKE_CUDA_ARCHITECTURES=90 \ |
There was a problem hiding this comment.
Since this is a var above I'm inclined to reference the var over a hard coded value
I can remove it in a subsequent PR so we don't delay yours being merged |
|
One more thought @mjschmidt271 if it makes sense to add a README like we had for PNNL CI? Seems like this was less complicated though |
Well, it appears to have been a one-off and is now passing 🧐 |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #426 +/- ##
==========================================
- Coverage 95.69% 95.68% -0.01%
==========================================
Files 46 46
Lines 9446 9438 -8
==========================================
- Hits 9039 9031 -8
Misses 407 407 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Hrmm! Well, here's what was reported, in case it rears its head again: |
|
Thanks a lot, Mike, for adding this testing pipeline! As @jaelynlitz mentioned, we can remove PNNL's pipeline in a separate PR. We might want to run both pipelines for a few PRs before removing PNNL's pipeline just to monitor both pipelines. |
This adds the AT2 workflow to test on SNL machines.
Currently, the only testing we do with this workflow is for GPU/cuda on H100 cards.
This autotesting workflow is triggered by pull requests to main and by a handful of actions on an open PR to main (e.g., reopened, converted to ready from draft, etc.).
A couple of notes (as I understand things--could be mistaken in minor ways):
.githubdirectory, a member of thesnl-testing-adminsteam must add theCI-AT2_special_approvalto kick off the autotesting.snl-testingteam, and only contains commits from members of that team should automatically trigger this autotesting.snl-testingteam or contains commits from someone outside of that team, an approving review by someone on thesnl-testingteam is required to trigger autotesting.Given the above, I have not been able to test the latter 2 conditions because my changes are not yet merged into
main